Merge pull request 'fix(smoke): capture arp-scan output instead of piping into awk' (#8 ) from fix-smoke-pipefail into main

Reviewed-on: #8
fix(smoke): capture arp-scan output instead of piping into awk
2026-04-18 15:43:50 +02:00 · 2026-04-18 15:26:10 +02:00
1 changed files with 9 additions and 4 deletions
--- a/scripts/smoke-vm.sh
+++ b/scripts/smoke-vm.sh
@ -153,14 +153,19 @@ MAC_LOWER="$(echo "$MAC" | tr 'A-Z' 'a-z')"
 IP=""
 deadline=$((SECONDS + 150))
 while (( SECONDS < deadline )); do
+  # Capture-then-parse instead of piping directly into awk. `awk '... exit'`
+  # exits on first match, which SIGPIPEs the upstream arp-scan (exit 141).
+  # With `set -o pipefail` active that kills the whole script — exactly what
+  # happened the first time host-networking gave arp-scan real matches.
+  SCAN=""
  if command -v arp-scan >/dev/null 2>&1; then
-    IP="$(sudo arp-scan --localnet --quiet --ignoredups 2>/dev/null \
-          | awk -v m="$MAC_LOWER" 'tolower($2) == m { print $1; exit }')"
+    SCAN="$(sudo arp-scan --localnet --quiet --ignoredups 2>/dev/null || true)"
+    IP="$(awk -v m="$MAC_LOWER" 'tolower($2) == m { print $1; exit }' <<<"$SCAN")"
  fi
  if [[ -z "$IP" ]] && command -v nmap >/dev/null 2>&1; then
    sudo nmap -sn -T4 192.168.178.0/24 >/dev/null 2>&1 || true
-    IP="$(ip neigh show \
-          | awk -v m="$MAC_LOWER" 'tolower($5) == m && $1 ~ /^[0-9]/ { print $1; exit }')"
+    NEIGH="$(ip neigh show)"
+    IP="$(awk -v m="$MAC_LOWER" 'tolower($5) == m && $1 ~ /^[0-9]/ { print $1; exit }' <<<"$NEIGH")"
  fi
  [[ -n "$IP" ]] && break
  sleep 5
Author	SHA1	Message	Date
daniel	850d656169	Merge pull request 'fix(smoke): capture arp-scan output instead of piping into awk' (#8 ) from fix-smoke-pipefail into main All checks were successful Build ISO / build-iso (push) Successful in 17m6s Details CI / lint (push) Successful in 26s Details CI / test (push) Successful in 33s Details CI / validate-json (push) Successful in 28s Details CI / markdown-links (push) Successful in 13s Details Reviewed-on: #8	2026-04-18 15:43:50 +02:00
Daniel Maksymilian Syrnicki	93c6b838a7	fix(smoke): capture arp-scan output instead of piping into awk All checks were successful CI / lint (pull_request) Successful in 26s Details CI / test (pull_request) Successful in 34s Details CI / validate-json (pull_request) Successful in 23s Details CI / markdown-links (pull_request) Successful in 14s Details When host-networking finally gave arp-scan a real LAN to scan, the first MAC-match emitted a line, awk hit its `exit` clause, closed the pipe, and arp-scan died from SIGPIPE (exit 141). With `set -o pipefail` active, that killed the whole smoke-vm.sh run immediately after "==> starting VM" — no IP discovery, no curl, no prune. Fix: capture arp-scan's output into a variable first, then let awk parse a here-string. Same treatment for the `ip neigh show` fallback. No pipe, no pipefail cascade. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-04-18 15:26:10 +02:00