Merge pull request 'chore(smoke): surface PVE response body on API failure' (#6 ) from debug-smoke-errors into main

Reviewed-on: #6
chore(smoke): surface PVE response body on API failure
2026-04-18 14:06:47 +02:00 · 2026-04-18 14:06:09 +02:00
1 changed files with 15 additions and 2 deletions
--- a/scripts/smoke-vm.sh
+++ b/scripts/smoke-vm.sh
@ -43,9 +43,22 @@ SHORT_SHA="${SHA:0:12}"
 API="https://${PVE_TEST_HOST}:8006/api2/json"

 api() {
-  curl --silent --show-error --fail-with-body -k \
+  # Wrapper so that on non-2xx we print the PVE response body to stderr
+  # before bubbling the failure — otherwise `--fail-with-body` output
+  # gets swallowed by callers that pipe to /dev/null, and you're left
+  # staring at "curl: (22)" with no idea which permission is missing.
+  local body rc
+  body=$(curl --silent --show-error --fail-with-body -k \
    --header "Authorization: PVEAPIToken=${PVE_TEST_TOKEN}" \
-    "$@"
+    "$@" 2>&1)
+  rc=$?
+  if [[ $rc -ne 0 ]]; then
+    echo "!! PVE API call failed (rc=$rc)" >&2
+    echo "!! request: $*" >&2
+    [[ -n "$body" ]] && echo "!! response: $body" >&2
+    return $rc
+  fi
+  printf '%s' "$body"
 }

 # PVE returns {"data": <payload>}; grab .data into a python expression.
Author	SHA1	Message	Date
daniel	931d62149f	Merge pull request 'chore(smoke): surface PVE response body on API failure' (#6 ) from debug-smoke-errors into main Some checks failed CI / validate-json (push) Waiting to run Details CI / markdown-links (push) Waiting to run Details Build ISO / build-iso (push) Has been cancelled Details CI / lint (push) Has been cancelled Details CI / test (push) Has been cancelled Details Reviewed-on: #6	2026-04-18 14:06:47 +02:00
Daniel Maksymilian Syrnicki	f4f7d853ba	chore(smoke): surface PVE response body on API failure Some checks failed CI / lint (pull_request) Successful in 1m3s Details CI / test (pull_request) Successful in 1m23s Details CI / markdown-links (pull_request) Has been cancelled Details CI / validate-json (pull_request) Has been cancelled Details api() was swallowing Proxmox's error body because callers pipe its output to /dev/null. With a bare "curl: (22) 403" in the log we can't tell which permission is missing. Now we capture the response body, print it to stderr on failure, and only emit it to stdout on success. No behaviour change on the happy path. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-04-18 14:06:09 +02:00